ci: allow opt-out of changelog lint for internal changes#4673
Merged
mergify[bot] merged 5 commits intomasterfrom Oct 17, 2023
Merged
ci: allow opt-out of changelog lint for internal changes#4673mergify[bot] merged 5 commits intomasterfrom
mergify[bot] merged 5 commits intomasterfrom
Conversation
Contributor
Author
|
Opening this as a an idea how we could resolve the changelog lint problem. It will result in a fair few labels over time but I think by namespacing them, they should all be easier to find still. |
thomaseizinger
added
the
trivial
Contributor
Author
|
Merging to unblock CI of other PRs. |
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We introduced a lint in #4620 that ensures the changelog is updated when we touch a certain crate. This however leads to many "false-positives" where a change to the source code is not actually worth mentioning in the changelog.
To opt out of this change, this patch adds a condition to the job that checks for a
internal:$cratelabel and if that is applied, it doesn't run the lint.Notes & open questions
Change checklist